[wp-trac] [WordPress Trac] #43545: Helper functions: Anonymizing data in a standardized way
WordPress Trac
noreply at wordpress.org
Thu Apr 12 17:34:57 UTC 2018
#43545: Helper functions: Anonymizing data in a standardized way
--------------------------------+---------------------
Reporter: dejliglama | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.0
Component: Options, Meta APIs | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch gdpr | Focuses:
--------------------------------+---------------------
Comment (by iandunn):
> No problems with new files in /tests. They are only problematic in
/build for minor releases.
Doh, good point :)
----
[attachment:43545.6.diff] has lots of good tweaks. A few minor questions:
* Should `@uses` be added? It sounds like
[https://make.wordpress.org/core/handbook/best-practices/inline-
documentation-standards/php/#phpdoc-tags the standard discourages it now],
and I personally feel like it adds a maintenance overhead without being
particularly useful.
* I don't think `inet_(ntop|pton)` `throw` any exceptions, so is there a
benefit of using `try/catch`?
* It looks like the changes to `src/wp-admin/includes/class-wp-community-
events.php` and `tests/phpunit/tests/admin/includesCommunityEvents.php`
were left out.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43545#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list