[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions
WordPress Trac
noreply at wordpress.org
Thu Apr 12 08:01:52 UTC 2018
#41191: Create browse happy type notice for PHP versions
-------------------------------------------------+-------------------------
Reporter: joostdevalk | Owner: flixos90
Type: enhancement | Status: reopened
Priority: normal | Milestone: 4.9.6
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch ui-feedback needs-testing | Focuses:
| accessibility
-------------------------------------------------+-------------------------
Comment (by danieltj):
Replying to [comment:92 karmatosed]:
> As has been asked, I am going to give a design review of this. I am
coming a little into this without knowing the history (so please consider
this).
>
> - That is a lot of text and expecting people to read it is quite the
ask. I think it should be collapsed by default or a lot less text.
> - That button (blue primary one) should not be full width. Make it fit
the text please.
> - I am unsure this should be a red error, perhaps it's more of a
warning?
Agree on these points here.
Button should be smaller (fit the text), the text reduced. I tried to
reduce some of it in [attachment:41191.11.diff] and the red should be
changed to a orange (warning colour) as whilst it's not broken per se,
**PHP should be upgraded**.
I am against having this collapsed by default though. If we have it
collapsed be default it won't have the effect that we're intending it to
have. It should be right in front of you to see it clearly.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:94>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list