[wp-trac] [WordPress Trac] #39318: Assign a theme when creating a site (Multisite)
WordPress Trac
noreply at wordpress.org
Mon Apr 9 15:45:37 UTC 2018
#39318: Assign a theme when creating a site (Multisite)
-------------------------------------+------------------------------
Reporter: Mista-Flo | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Networks and Sites | Version: 3.0
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: multisite
-------------------------------------+------------------------------
Comment (by flixos90):
Thanks for the update @Mista-Flo!
Just a few minor observations regarding [attachment:39318.4.patch] (some
of which I could have noticed earlier, sorry about that):
* The comment on line 70 can be removed. We're not looking at
`WP_DEFAULT_THEME` there.
* In line 73 and 74, the equal signs should be aligned.
* The comment on line 76 can be removed.
* In line 78, the site should not be enabled on the network, but on the
new site. Enabling it for the entire network would be unexpected.
* In line 297, you can remove the `is_array()` check, the return value of
`wp_get_themes()` should always be an array.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39318#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list