[wp-trac] [WordPress Trac] #37392: Multisite "Sites" screen: Add links to filter websites by status

[WordPress Trac]

#37392: Multisite "Sites" screen: Add links to filter websites by status
----------------------------------------+------------------------------
 Reporter:  thomaswm                    |       Owner:  mnelson4
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Networks and Sites          |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+------------------------------

Comment (by mnelson4):

 > all should probably not be part of the $slug_to_label array, as it's not
 a status and its link should have a different structure (it shouldn't do
 ?status=all, but instead should not add any status query arg). See how
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 wp-posts-list-table.php#L323 does that.

 I hear you that there shouldn't be a link with `?status=all`, so I made an
 adjustment that avoids that, but I do prefer how having `all` be in the
 array is avoids quite a bit of repeated code. If you still prefer not
 having `all` in the array, I can make another patch that does that.

 > here are a number of missing blank lines there

 I'm not sure where there should be blank lines. I double-checked the WP
 coding standards and don't see anything about where there should be blank
 lines. Could you point me to some documentation or help me see where blank
 lines are needed?

 >  some parts are incorrectly indented.

 I double-checked that it's using real tabs instead of spaces for
 indentation and don't see where the indentation is wrong, sorry!

 I hope this is a bit better though

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37392#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform