[wp-trac] [WordPress Trac] #10653: Update comment_author when display_name changes

[WordPress Trac]

#10653: Update comment_author when display_name changes
-------------------------+-----------------------------
 Reporter:  mptre        |       Owner:
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  Future Release
Component:  Comments     |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+-----------------------------
Changes (by matjack1):

 * keywords:  has-patch needs-testing needs-refresh => has-patch
 * version:   => trunk


Comment:

 I've just added a patch working on WP 5.0.0 with the missing tests.

 I've written the tests first on the current function and then updated with
 the one in the patch. This showed a different behaviour that I've now
 fixed, but please let me know if you agree with my refactoring.

 Plus I was wondering if we should pass the `$before_alias` and
 `$after_alias` also in the `comment_author` function.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/10653#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform