[wp-trac] [WordPress Trac] #43587: UI adjustments to the Status box in the Edit Comment screen

[WordPress Trac]

#43587: UI adjustments to the Status box in the Edit Comment screen
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  5.0
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:  invalid
 Keywords:  ui-feedback has-screenshots good-    |     Focuses:  ui,
  first-bug has-patch                            |  administration
-------------------------------------------------+-------------------------
Changes (by nfmohit):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thank you so much for checking the patch out @birgire !

   @afercia suggested here (#2) that we should display the radio buttons by
 default and not use the extra "Edit" link to display it, for accessibility
 reasons.
 I'm sorry I completely misunderstood that part. I initially intended to
 make the comment status radio buttons mimic the post status selection as
 we can see in the posts and pages, but after @afercia's comment, I went
 with the radio buttons instead of the selection. Didn't realize we were
 referring to the "Edit" toggle link. My bad. I have removed that in this
 patch [attachment:43587.3.diff].

   On that screenshot I also added an extra left margin on the holders of
 the form inputs. What do you think? (I opened the timestamp edit, just to
 better show the alignment there)
 I really like the idea of pushing the form inputs a little to the right
 aligning them with their section headers, but I haven't added it in the
 patch yet as I think we require more opinions on this. I believe if we are
 going to implement this, it'll also apply to the similar sections like
 post status and visibility selection in posts and pages, as we are trying
 to keep the layout consistent between comments and post types. If everyone
 is okay with it, I'll update my patch with that applied. Opinions?

   Do we need the bold status text, shown in the screenshot? It could help
 to see the previous status, if we've changed it (without saving). It's
 also in-line with e.g. the timestamp layout.
 I really prefer keeping the bold text showing the current comment status,
 it is static now though and doesn't change when a different status is
 selected (until the comment is saved, of course).

   So should the icons be added via `aria-hidden` span tags here, instead
 of adding them via CSS generated content?
 I'd also prefer adding the icons via `aria-hidden` span tags, but I also
 need more opinions here as CSS generated content is being used
 consistently in other sections like post status, post visibility and
 timestamp in post types.

 Personally, I think if we are going to add the left margins to the form
 holders and change to using `aria-hidden` span tags for the icons, we'd
 like to do that globally in posts and other sections as well. Opinions?

 Thank you so much!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43587#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform