[wp-trac] [WordPress Trac] #33981: Default Captions Should Use max-width

WordPress Trac noreply at wordpress.org
Fri Sep 29 16:38:25 UTC 2017


#33981: Default Captions Should Use max-width
---------------------------------------------+------------------------
 Reporter:  Howdy_McGee                      |       Owner:  joemcgill
     Type:  enhancement                      |      Status:  assigned
 Priority:  normal                           |   Milestone:  4.9
Component:  Media                            |     Version:  4.3.1
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  ui
---------------------------------------------+------------------------
Changes (by joemcgill):

 * keywords:  has-patch has-unit-tests 2nd-opinion => has-patch has-unit-
     tests commit


Comment:

 @desrosj, [attachment:33981.3.patch] looks good to me. It may be a bit
 cleaner to use a data provider for the new shortcode tests, but that's
 certainly not a blocker. While testing this I noticed an additional test
 that was failing in `tests/phpunit/tests/shortcode.php`, which I've
 updated in [attachment:33981.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33981#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list