[wp-trac] [WordPress Trac] #42022: Customize: Fix date time control label (was: Customizer: Change "day" to "date" in scheduling)

WordPress Trac noreply at wordpress.org
Thu Sep 28 19:35:27 UTC 2017


#42022: Customize: Fix date time control label
--------------------------+--------------------------
 Reporter:  melchoyce     |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui
--------------------------+--------------------------
Changes (by westonruter):

 * status:  new => accepted
 * owner:   => westonruter
 * keywords:  needs-patch good-first-bug => needs-patch
 * type:  enhancement => defect (bug)


Old description:

> See attached image.
>
> Located in "Customize" —> click the cog next to "Publish" —> click
> "Schedule"

New description:

 See attached image. “Day” should be replaced with “Date”.

 Located in "Customize" —> click the cog next to "Publish" —> click
 "Schedule"

 * The control should be able to be re-used for multiple settings
 (currently it can't).
 * Changes to the setting should sync into the control.
 * The `defaultValue` param should be replaced with using the value that is
 provided to the setting when instantiating (see #37964).
 * The time portion the control should be able to be optional.
 * The `maxlength` is not appropriate for `number` inputs.
 * “form elements label are not explicitly associated with for/id
 attributes as required by the accessibility standard for any new code in
 core.” ([https://wordpress.slack.com/archives/C0381N237/p1506612587000161
 via] @afercia)
 * “the preview link contains a few error that are easily catchable just
 validating the HTML, most notably: a label element can contain just one
 labelable element”
 ([https://wordpress.slack.com/archives/C0381N237/p1506612775000090 via]
 @afercia)
 * “In the template, there are a couple inputs with attributes with a
 double quote at the end”
 ([https://wordpress.slack.com/archives/C0381N237/p1506613180000846 via]
 @afercia)

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42022#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list