[wp-trac] [WordPress Trac] #22101: Gallery shortcode with link="file" is not linking the file in the RSS feed

[WordPress Trac]

#22101: Gallery shortcode with link="file" is not linking the file in the RSS feed
-------------------------------------------------+-------------------------
 Reporter:  ifrins                               |       Owner:  iworks
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Feeds                                |  Review
 Severity:  normal                               |     Version:  3.4.2
 Keywords:  good-first-bug has-patch has-unit-   |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by birgire):

 * keywords:  needs-testing good-first-bug has-patch => good-first-bug has-
     patch has-unit-tests


Comment:

 Added a test in [attachment:22101.3.patch] for the cases mentioned by
 @stevenkword (apart from the link attribute as an url, as it's not
 supported afaik).

 As unrelated, I noticed that the test in
 {{{test_wp_get_attachment_image_should_use_wp_get_attachment_metadata()}}}
 can only run once, because the filename gets an increasing index, like
 {{{test-image-large-{$i}-150x150.png}}} in the srcset, where {{{$i > 2}}}
 is the number of times we run the {{{/tests/phpunit/tests/media.php}}}
 tests. Looks like we might need a better cleanup there?

 I tried to avoid this in the above test by not referring to the exact
 filename.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22101#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform