[wp-trac] [WordPress Trac] #41561: Remove usage of DOING_AJAX in the test suite

WordPress Trac noreply at wordpress.org
Wed Sep 27 12:07:01 UTC 2017


#41561: Remove usage of DOING_AJAX in the test suite
------------------------------+--------------------------
 Reporter:  johnbillion       |       Owner:  johnbillion
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  4.9
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by matthias.thiel):

 I am not sure the current implementation resolves the issue properly.
 Adding a filter in the static `setUpBeforeClass` method will still exist
 in test cases that are run later. I advise putting the hook into the
 `setUp` method like the `wp_die_ajax_handler` hook.

 I think this would also be more in line with the `WP_UnitTestCase` class
 as it backs up all hooks in the `setUp` method.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41561#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list