[wp-trac] [WordPress Trac] #17268: Use native gettext library when available

WordPress Trac noreply at wordpress.org
Mon Sep 25 18:22:31 UTC 2017


#17268: Use native gettext library when available
-------------------------------------------------+-------------------------
 Reporter:  linushoppe                           |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  I18N                                 |  Release
 Severity:  normal                               |     Version:
 Keywords:  early has-patch needs-refresh        |  Resolution:
  needs-unit-tests                               |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by Mte90):

 I tried that patch with PHPunit and as I can see there are this errors
 that are caused by the php native module:
 {{{
 There were 2 failures:

 1) Tests_POMO_MO::test_nplurals_with_backslashn
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'%d foro'
 +'%d forum'

 /home/www/VVV/www/wordpress-
 develop/public_html/tests/phpunit/tests/pomo/mo.php:117

 2) Tests_POMO_MO::test_load_pot_file
 Failed asserting that true matches expected false.

 /home/www/VVV/www/wordpress-
 develop/public_html/tests/phpunit/tests/pomo/mo.php:141
 }}}

 As I can see the native module/native.php doesn't handle the malformed
 po/pot file like the PHP version. I will investigate :-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17268#comment:90>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list