[wp-trac] [WordPress Trac] #41936: get_main_site_id ignores custom values of $current_site->blog_id

[WordPress Trac]

#41936: get_main_site_id ignores custom values of $current_site->blog_id
--------------------------------------+------------------------------------
 Reporter:  spacedmonkey              |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.9
Component:  Networks and Sites        |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:  multisite,
                                      |  performance
--------------------------------------+------------------------------------
Changes (by flixos90):

 * milestone:  Awaiting Review => 4.9


Comment:

 I agree this can become a bug in some cases, thus should be fixed in 4.9.

 [attachment:41936.diff] fixes it, but I still don't like the logic being
 part of the `WP_Network` method, as this is not a common practice. It may
 very well be the only solution to accomplish this, but I wanna try to
 think further about another way. This can go in post-beta, so we don't
 need to rush.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41936#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform