[wp-trac] [WordPress Trac] #40187: The tag cloud should output a list
WordPress Trac
noreply at wordpress.org
Fri Sep 22 07:09:48 UTC 2017
#40187: The tag cloud should output a list
--------------------------+------------------------------------------------
Reporter: afercia | Owner: davidakennedy
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.9
Component: Taxonomy | Version:
Severity: normal | Resolution:
Keywords: tag-cloud | Focuses: ui, accessibility, administration
has-patch |
--------------------------+------------------------------------------------
Comment (by afercia):
While not strictly related to this ticket, I'd say making `tagchecklist` a
list it a nice addition :) The benefit is that a proper semantics gets
used by software to announce what actually is a list of selected tags as a
list, including the number of items in the list.
Worth noting Safari 10 has a bug: when lists are styled removing the
"bullets", it doesn't expose the list as a list to assistive technologies.
That's the reason why sometimes we're adding `role="list"` to a `<ul>`:
it's redundant (and the HTML validator will throw a warning) but makes
Safari happy and should be done here as well.
Some screenshots when arrowing through content with Safari and VoiceOver:
[[Image(https://cldup.com/B-VW8YJ_zM.png)]]
[[Image(https://cldup.com/jXM5fVkuOe.png)]]
[[Image(https://cldup.com/hSwPGO0zEs.png)]]
The patch looks good to me at a first glance, just a couple things:
- as far as I know, `display: inline-block;` on a floated element doesn't
do anything
- coding standards: please check spaces within parenthesis, e.g.
`('filter' => 0, 'format' => 'list')` and `$('<li />').text( val )`
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40187#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list