[wp-trac] [WordPress Trac] #39693: Fix missing assignment of widgets on theme switch

[WordPress Trac]

#39693: Fix missing assignment of widgets on theme switch
--------------------------------------+------------------------
 Reporter:  melchoyce                 |       Owner:  obenland
     Type:  enhancement               |      Status:  reviewing
 Priority:  high                      |   Milestone:  4.9
Component:  Widgets                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by poena):

 Hi
 I did not see the recent update so I have only tested 39693.10 (on
 4.9-alpha-40870).

 I did a lot of switching back and forward, mostly with parent themes.
 One thing I noticed was that sometimes the individual widgets were
 duplicated in the same widget area.
 I also think it might be hard for new users to see how to make the
 inactive widgets show again.

 When trying to reproduce the duplicate widget problem, I wrote down the
 latest test:

 Fresh install
 Go to customizer and save the starter content widgets in Twenty Seventeen.
 Change to Twenty Sixteen, add new widgets to any of the widget areas.
 Change back to Twenty Seventeen. The widgets displays correctly.
 Change to Twenty Thirteen. The starter content text widgets from Twenty
 Seventeen are now duplicated in the "main" widget area.
 Change back to Twenty seventeen. The widgets are no longer duplicated.
 Installed a random theme from the latest themes list, (stripe) the widgets
 displayed correctly.
 Installed a random child theme from the latest themes list (katlan), the
 widgets displayed correctly.
 Changed back to Twenty Seventeen. Only one widget area is showing widgets
 on the front and in the customizer preview (the blog sidebar).
 All the widgets are present in the customizer sidebar, but the the widgets
 that are not showing on the page preview are greyed out. I assumed that
 this meant they are inactive.
 I checked if perhaps I could press the customizer save button in order to
 restore the greyed out widgets, but the button already says saved, so that
 did not work.
 I tried to see if I could expand the widgets themselves and see if there
 was a save or "restore" option there, but I could only see links for
 "Remove" and "Done"
 Clicking the Done link did not help me restore my widget, it only
 collapsed it.
 In this widget area there was only one widget. Clicking "Reorder" and then
 "Done" also did not restore my widget.
 In order to make the widget display in the widget area in the page
 preview, I had to add a new widget.
 Once I added another widget, the previously greyed out widget was no
 longer greyed out.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39693#comment:108>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform