[wp-trac] [WordPress Trac] #41944: Add %u support to wpdb->prepare

WordPress Trac noreply at wordpress.org
Thu Sep 21 14:52:08 UTC 2017


#41944: Add %u support to wpdb->prepare
--------------------------+------------------------------
 Reporter:  charlestonsw  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Database      |     Version:  4.8.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by soulseekah):

 Well 1.2 million lines of code, according to GitHub search
 https://github.com/search?q=wpdb-%3Eprepare+%251%24s&type=Code&utf8=%E2%9C%93
 broke on usage of numbered placeholders (I and didn't even look for
 variations of the placeholders). But as you can see my ticket was closed
 and wontfix.

 I wrote some thoughts about this here https://codeseekah.com/2017/09/21
 /on-wordpress-security-and-contributing/

 And indeed, %u is has nothing to do with the security concern. But the
 official stance of the higher-ups seems to be that if it's wasn't
 supported and documented in the code then it's your problem, it won't be
 fixed.

 My strong belief is that if it is useful, if it was used, the possibility
 of adding it for that sake should not be discounted so strongly.

 Placeholders - useful. Used? - a freaking lot! Should be considered -
 definitely.

 %u - not useful. Used? - I guess so, otherwise this ticket would not be
 here. Should be considered - hell yes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41944#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list