[wp-trac] [WordPress Trac] #39693: Fix missing assignment of widgets on theme switch

[WordPress Trac]

#39693: Fix missing assignment of widgets on theme switch
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:  obenland
     Type:  enhancement                          |      Status:  reviewing
 Priority:  high                                 |   Milestone:  4.9
Component:  Widgets                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by xkon):

 @obenland , @westonruter , after a long night of going back and forth on
 over 60 themes both non & commercial I can say this.

 First of all, as you informed me yesterday it depends on how the
 placeholders are named so some times it was confusing as from a sidebar
 the widgets where ending up on a footer etc ( TA-DA! feeling ) as the
 theme developers where playing trick on the code side as well x_X . So
 that won't be counted at all or counted as correct since that's what the
 code is supposed to do :)

 All switches back and forth having where working as expected as
 @westonruter said above as well. So that's goody good.

 Most of the time even if the placeholders where a lot more in 1 of the 2
 test-combined themes when switching most of the widgets would end up in a
 similar position as the previous and surely return back to the correct one
 when reverting back.

 No idea what else to check but I guess in an overall viewing with serious
 clicking of activates and refreshes it seems to be working as expected.
 Not that obvious in some cases as I mentioned but at least working. :D

 Hopefully this is a little bit helpful as well as on my watch it was
 working as expected at least from what I understand.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39693#comment:104>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform