[wp-trac] [WordPress Trac] #41919: Image Widget Custom Link Target
WordPress Trac
noreply at wordpress.org
Tue Sep 19 10:23:59 UTC 2017
#41919: Image Widget Custom Link Target
-----------------------------+-----------------------------
Reporter: Nenad Obradovic | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Widgets | Version: 4.8.1
Severity: normal | Keywords:
Focuses: |
-----------------------------+-----------------------------
Hi,
I think there is a small issue inside WP_Widget_Media_Image Class with
link_target_blank option, when you render html code for this widget (code
below) you only set target value to be _blank if this option is set in
otherwise target value is empty and HTML validator mark this empty target
value as error because that attribute can't be empty. Thanks
{{{
! empty( $instance['link_target_blank'] ) ? '_blank' : '',
}}}
Best regards,
Nenad
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41919>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list