[wp-trac] [WordPress Trac] #39275: Improve wp.customize.previewer.save() for changesets.

[WordPress Trac]

#39275: Improve wp.customize.previewer.save() for changesets.
-------------------------+-------------------------
 Reporter:  sayedwp      |       Owner:  sayedwp
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.9
Component:  Customize    |     Version:  4.7
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  javascript
-------------------------+-------------------------
Changes (by westonruter):

 * owner:  westonruter => sayedwp
 * status:  accepted => assigned


Comment:

 @sayedwp What are the scenarios where `wp.customize.previewer.save()`
 would need to be called directly? Are the use cases not now actually
 better served by calling `wp.customize.requestChangesetUpdate()` if no
 revision is desired to be made?

 See also: https://github.com/xwp/wordpress-
 develop/pull/258/commits/dfe16326127c9007d903d60322d285d509003c4b

 In regards to [attachment:39275_version2.patch], a couple bits of
 feedback:

 * `filter_var()` isn't used in core, so we'd to use an alternative.
 * This logic seems backwards: `$allow_revision = (bool)
 $args['skip_revision'];`. If we're skipping should this not mean a
 revision is //disallowed//?

 But if this change isn't actually required, then no need to update the
 patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39275#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform