[wp-trac] [WordPress Trac] #34115: oEmbed not working on author page without posts

WordPress Trac noreply at wordpress.org
Fri Sep 15 22:23:09 UTC 2017


#34115: oEmbed not working on author page without posts
-------------------------------------------------+-------------------------
 Reporter:  dannydehaan                          |       Owner:  swissspidy
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9
Component:  Embeds                               |     Version:  2.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  template,
  refresh                                        |  performance
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * focuses:  template => template, performance


Comment:

 Copying the [https://github.com/xwp/wordpress-
 develop/pull/254#issuecomment-329917396 latest comment] from the PR here
 for visibility:

 >> It would be great if we could migrate post meta caches over to the post
 type instead of bumping the cache time there.
 >
 >I think it's going to be more performant to continue using the postmeta
 cache by default. Consider having an index page for videos where you are
 showing 30 posts, each of which has an oEmbed. When postmeta caches are
 used, when the `WP_Query` is made, WordPress will
 [https://github.com/WordPress/wordpress-
 develop/blob/203cb6f4a26d3b5bede1235c960d942f7398ce07/src/wp-includes
 /class-wp-query.php#L2993 update post caches] of the postmeta for _all_ of
 the queried posts at once via `update_post_caches()`.
 >
 >If, however, oEmbed caches are stored in a custom post type, then these
 will not be able to be fetched en-mass and a separate DB query will result
 for every oEmbed in every post.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34115#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list