[wp-trac] [WordPress Trac] #12423: Include default code editor

[WordPress Trac]

#12423: Include default code editor
------------------------------+----------------------------
 Reporter:  scribu            |       Owner:  westonruter
     Type:  feature request   |      Status:  accepted
 Priority:  normal            |   Milestone:  4.9
Component:  Editor            |     Version:  3.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  accessibility
------------------------------+----------------------------
Changes (by westonruter):

 * keywords:   => has-patch commit


Comment:

 I have here a core patch in a PR that is now awaiting finalization of the
 Travis build. Once the jobs finish and it passes, I'm going to commit this
 to core: https://github.com/xwp/wordpress-develop/pull/255/files

 Please open any defects in new tickets.

 A few possible things to follow up on:

 * I'm aware that it would be ideal if the CodeMirror bundling logic (via
 browserify) could be added as part of core. For now, just the minified
 bundles are being included.
 * The linters are being included as separate assets. They are not being
 minified, other than they are already minified as distributed. These could
 either benefit from additional uglification or bundling with codemirror if
 they are not going to be enqueued separately.
 * PHPUnit tests should be added for `wp_enqueue_code_editor()` and
 `WP_Widget_Custom_HTML`.
 * There is no PHP linter yet. This would be a good enhancement. See
 https://github.com/WordPress/better-code-editing/issues/48
 * While there is an HTMLHint rule which checks for Kses violations, this
 does not extend to CSSLint and `safecss_filter_attr()`. It would be a nice
 enhancement to get illegal style properties flagged as lint errors as
 well. See https://github.com/WordPress/better-code-editing/issues/60

 Again, these should get opened as separate tickets.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12423#comment:145>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform