[wp-trac] [WordPress Trac] #41285: Remove $site_id and $public multisite globals that are no longer used

[WordPress Trac]

#41285: Remove $site_id and $public multisite globals that are no longer used
--------------------------------+-------------------------
 Reporter:  earnjam             |       Owner:  jeremyfelt
     Type:  defect (bug)        |      Status:  reviewing
 Priority:  normal              |   Milestone:  4.9
Component:  Networks and Sites  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+-------------------------

Comment (by jeremyfelt):

 Thanks for the patch, @tejas5989!

 It looks like we need to be careful with `$site_id`.
 [https://github.com/Automattic/vip-go-mu-
 plugins/blob/98cdea08397ce37764ec50ced45dbc65b0c94501/vaultpress/vp-
 scanner.php#L78-L82 VaultPress is using it] for something, likely in the
 WPCOM environment. If anyone has details on the safeness of removing that,
 please chime in. :)

 I've poked around quite a bit and can't find anyone using `$public`. I
 feel pretty comfortable about removing that one, but will keep digging.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41285#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform