[wp-trac] [WordPress Trac] #39419: Explicitly globalize global variables in ms-settings.php

[WordPress Trac]

#39419: Explicitly globalize global variables in ms-settings.php
-------------------------------------------------+-------------------------
 Reporter:  danielbachhuber                      |       Owner:  csloisel
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.9
Component:  Bootstrap/Load                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug needs-docs needs-     |     Focuses:  multisite
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * keywords:  good-first-bug has-patch needs-testing needs-docs => good-
     first-bug needs-docs needs-patch
 * owner:  jeremyfelt => csloisel


Comment:

 It looks like we can do a bit more with the patch. A couple notes:

 * We'll need documentation next to each global that describes its purpose.
 * `$table_prefix` should be documented in `wp-settings.php` instead of
 `ms-settings.php`.
 * We can remove `$site_id` and `$public`. See #41285.

 @csloisel - if you are interested, please feel free to update the ticket
 with a new patch. I'm going to reassign the ticket to you.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39419#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform