[wp-trac] [WordPress Trac] #38925: Allow override of depth limits on comment reply link

[WordPress Trac]

#38925: Allow override of depth limits on comment reply link
-------------------------------------------------+-------------------------
 Reporter:  TravisR                              |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Comments                             |  Review
 Severity:  normal                               |     Version:  4.7
 Keywords:  has-patch dev-feedback has-unit-     |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by birgire):

 * keywords:  has-patch dev-feedback => has-patch dev-feedback has-unit-
               tests


Comment:

 Thank you for the patch @TravisR

 I remember looking into workarounds previously here:

 https://wordpress.stackexchange.com/questions/235356/how-to-enable-reply-
 on-most-deeply-nested-comments/235374#235374

 https://wordpress.stackexchange.com/questions/215575/how-to-allow-the-
 reply-link-to-remain-on-the-comment-form-after-i-have-
 reached-m/215590#215590

 so I was planning to create a ticket for this, when I found this one ;-)

 When writing the tests I noticed that the comment validation was missing,
 so I created another ticket #41846 for that.

 The patch in [attachment:0001-Support-override-of-depth-constraint-on-
 reply-link.patch] broke the two existing tests in
 {{{Tests_Comment_GetCommentReplyLink}}}, because of the missing the
 comment validation in {{{get_comment_reply_link()}}}.

 I included the comment validation in [attachment:38925.2.patch] and
 rearranged it a little bit from the previous patch.

 In [attachment:38925.2.patch] I updated the [attachment:0001-Support-
 override-of-depth-constraint-on-reply-link.patch] to the current version,
 with documentation and few tests.

 I'm wondering about the name of the {{{limit_by_depth}}} argument, if it
 could better describe it's purpose? Maybe as {{{hide_below_max_depth}}},
 {{{max_depth_hidden}}}, {{{show_only_above_max_depth}}} .... But I'm not
 sure ;-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38925#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform