[wp-trac] [WordPress Trac] #41417: Error when opening up Thickbox lightbox on plugins page

[WordPress Trac]

#41417: Error when opening up Thickbox lightbox on plugins page
----------------------------------------------+----------------------------
 Reporter:  moeloubani1                       |       Owner:  afercia
     Type:  defect (bug)                      |      Status:  closed
 Priority:  normal                            |   Milestone:  4.9
Component:  Administration                    |     Version:  4.5
 Severity:  normal                            |  Resolution:  fixed
 Keywords:  has-screenshots has-patch commit  |     Focuses:  ui,
                                              |  javascript
----------------------------------------------+----------------------------
Changes (by afercia):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"41356"]:
 {{{
 #!CommitTicketReference repository="" revision="41356"
 Administration: Thickbox: Fix conflicts with the Plugin details and native
 Thickbox modals.

 The Plugin details modal custom implementation in the Plugins page
 conflicts with
 other Thickbox instances added by plugins. Thickbox shows its age and has
 been
 modified over time to suit core needs. However, WordPress should do its
 best to
 not create conflicts with the native Thickbox styles and functionalities.
 Plugin
 authors should be able to use `add_thickbox()` in any admin page as
 documented,
 without having to worry about potential errors.

 - fixes a JavaScript error when closing a native Thickbox modal in the
 Plugins page
 - avoids to override the native Thickbox modal styles
 - uses a CSS class to target the Plugin details modal and remove a pile of
 overqualified CSS selectors

 Fixes #41417.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41417#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform