[wp-trac] [WordPress Trac] #41610: Widgets: Change "close" to "done?"

WordPress Trac noreply at wordpress.org
Fri Sep 8 19:11:03 UTC 2017


#41610: Widgets: Change "close" to "done?"
-------------------------+--------------------------
 Reporter:  melchoyce    |       Owner:  westonruter
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  4.9
Component:  Widgets      |     Version:
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:
-------------------------+--------------------------
Changes (by westonruter):

 * owner:   => westonruter
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"41352"]:
 {{{
 #!CommitTicketReference repository="" revision="41352"
 Widgets: Add dirty state tracking for widgets on admin screen.

 * Mark a widget as dirty when a field input triggers a `change` or `input`
 event; clear dirty state when widget is successfully saved.
 * Disable Save button and re-label "Saved" when widget not dirty.
 * Show AYS dialog when leaving widgets admin screen with unsaved changes.
 * When widgets are dirty, expand all unsaved widgets at AYS check and
 focus on first one.
 * Change "Close" link to "Done"; hide link when widget is dirty and reveal
 when saved.
 * The "Done" link persistently appears in the Customizer even after making
 a change (when the widget is dirty) because changes are autosaved into the
 changeset.
 * Prevent saving widget when form fails `checkValidity`.
 * Fix frequency of triggering of `change` event on the rich Text widget's
 `textarea` limited now to when there are actual changes.
 * Add a class of `widget-dirty` to widget containers when the widget has
 unsaved changes.

 Props westonruter, timmydcrawford, melchoyce.
 Fixes #41610, #23120.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41610#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list