[wp-trac] [WordPress Trac] #41837: WP_User_Query can generate negative offset in the LIMIT clause

[WordPress Trac]

#41837: WP_User_Query can generate negative offset in the LIMIT clause
--------------------------+------------------------------
 Reporter:  birgire       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Users         |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Changes (by SergeyBiryukov):

 * component:  Query => Users


Old description:

> The {{{paged}}} argument in {{{WP_User_Query}}} was introduced in #34531
>
> There's a problem with the {{{paged}}} as 0 case.
>
> There's a similar ticket for {{{WP_User_Query}}}: #41826
>
> '''Example:
> '''
> When {{{paged}}} is 0 and number is 2, {{{WP_User_Query}}} generates the
> LIMIT clause:
>

> {{{
> LIMIT -2, 2
> }}}
>
> instead of
>

> {{{
> LIMIT 0, 2
> }}}
>
> According to the MySQL documentation, the offset in the LIMIT clause
> shouldn't be negative:
>
> https://dev.mysql.com/doc/refman/5.7/en/select.html
>
> I think we should handle it in the same way as in {{{WP_Query}}}, where
> the 0 case is the same as 1.

New description:

 The {{{paged}}} argument in {{{WP_User_Query}}} was introduced in #34531

 There's a problem with the {{{paged}}} as 0 case.

 There's a similar ticket for {{{WP_Comment_Query}}}: #41826

 '''Example:
 '''
 When {{{paged}}} is 0 and number is 2, {{{WP_User_Query}}} generates the
 LIMIT clause:


 {{{
 LIMIT -2, 2
 }}}

 instead of


 {{{
 LIMIT 0, 2
 }}}

 According to the MySQL documentation, the offset in the LIMIT clause
 shouldn't be negative:

 https://dev.mysql.com/doc/refman/5.7/en/select.html

 I think we should handle it in the same way as in {{{WP_Query}}}, where
 the 0 case is the same as 1.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41837#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform