[wp-trac] [WordPress Trac] #41826: WP_Comment_Query can generate negative offset in LIMIT clause

WordPress Trac noreply at wordpress.org
Thu Sep 7 11:49:59 UTC 2017


#41826: WP_Comment_Query can generate negative offset in LIMIT clause
--------------------------------------+------------------------------
 Reporter:  birgire                   |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Query                     |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------
Changes (by birgire):

 * keywords:   => has-patch has-unit-tests


Comment:

 Here we treat {{{paged}}} 0 as the default value, i.e. 1.

 We try to show it explicitly in the code, so it's more obvious to the
 reader, similar how it's done in {{{WP_Query}}}.

 Included a test for this case.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41826#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list