[wp-trac] [WordPress Trac] #41818: Add widget-title to default widget for consistency

WordPress Trac noreply at wordpress.org
Wed Sep 6 18:19:49 UTC 2017


#41818: Add widget-title to default widget for consistency
-----------------------------+------------------------------
 Reporter:  wpsmith          |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  lowest           |   Milestone:  Awaiting Review
Component:  Widgets          |     Version:  trunk
 Severity:  minor            |  Resolution:
 Keywords:  has-patch close  |     Focuses:
-----------------------------+------------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch close


Comment:

 This has been reported and closed previously in #39408 and #38244.

 If a theme wants to use `widget-title`, then they just have to supply the
 `before_title` when they register the sidebar, like Twenty Seventeen
 [https://github.com/WordPress/wordpress-
 develop/blob/706daad00dd92feb2663f66d42c9fd465acda9b1/src/wp-
 content/themes/twentysixteen/functions.php#L161 does].

 I think adding a secondary class name in the default `before_title` just
 adds bloat for the sake of consistency, and it could introduce backwards-
 compatibility problems if there is any CSS selectors for other elements
 that have the `widget-title` class.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41818#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list