[wp-trac] [WordPress Trac] #41489: Customize Preview: do not show `cursor: not-allowed` on audio/video track titles within playlists

WordPress Trac noreply at wordpress.org
Tue Sep 5 23:57:25 UTC 2017


#41489: Customize Preview: do not show `cursor: not-allowed` on audio/video track
titles within playlists
-------------------------------------+------------------
 Reporter:  celloexpressions         |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.9
Component:  Customize                |     Version:  4.7
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:  ui
-------------------------------------+------------------
Changes (by westonruter):

 * keywords:  good-first-bug needs-testing has-patch => needs-testing has-
     patch


Comment:

 @scott.deluzio The `hasClass` method is for a jQuery object. The `element`
 here is an `HTMLAnchorElement`, so that is why `classList.contains()`
 works instead. However, elsewhere in the function it's already doing `$(
 element )` multiple times, so it makes sense to just create a `$element`
 and then `hasClass` can be used. See [attachment:41489.3.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41489#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list