[wp-trac] [WordPress Trac] #38759: Accessibility glitch when editing an embedded video

[WordPress Trac]

#38759: Accessibility glitch when editing an embedded video
---------------------------------------+----------------------------
 Reporter:  Presskopp                  |       Owner:  joemcgill
     Type:  defect (bug)               |      Status:  reviewing
 Priority:  normal                     |   Milestone:  4.9
Component:  Media                      |     Version:  3.9
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  needs-patch has-screenshots => has-screenshots has-patch
 * milestone:  Future Release => 4.9


Comment:

 Looking a bit into this, there are a few occurrences in the media
 templates where `<label>` elements are used incorrectly:
 - to wrap just text (no form controls)
 - to wrap an input field and a button
 - to wrap a mix of the two cases above

 Label elements should be used just for labelable elements.
 [attachment:38759.diff] is a first attempt to fix most of these cases and
 produce valid, semantic markup. As per the
 [https://make.wordpress.org/core/handbook/best-practices/coding-standards
 /accessibility-coding-standards/#labeling accessibility standards], labels
 should be associated using for/id attributes.

 The patch can be certainly improves and need testing. Given how so badly
 associated labels impact accessibility, I'd like to propose to try to fix
 this in 4.9.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38759#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform