[wp-trac] [WordPress Trac] #39120: Add get/set methods to remaining main query classes (comments and terms)
WordPress Trac
noreply at wordpress.org
Sat Sep 2 15:01:40 UTC 2017
#39120: Add get/set methods to remaining main query classes (comments and terms)
--------------------------------------+------------------------------
Reporter: Offereins | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Query | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------------
Changes (by birgire):
* keywords: => has-patch has-unit-tests
Comment:
I agree with @Offereins here, I think it's good to have a get/set methods
consistency in the query classes.
Above I attached the {{{Tests_Comment_Query::test_get_and_set()}}} and
{{{Tests_Term_Query::test_get_and_set()}}} tests based on the
{{{Tests_User_Query::test_get_and_set()}}} test.
I also updated the patches, based on the {{{WP_User_Query::get()}}}
discussion here:
https://core.trac.wordpress.org/ticket/21426
regarding the null vs empty string return value for non-existing query
variables.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39120#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list