[wp-trac] [WordPress Trac] #39893: Twenty Seventeen: Full Screen Video Header
WordPress Trac
noreply at wordpress.org
Tue Oct 31 18:34:44 UTC 2017
#39893: Twenty Seventeen: Full Screen Video Header
---------------------------+------------------------------
Reporter: cingrosso | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version: 4.7.2
Severity: normal | Resolution:
Keywords: | Focuses:
---------------------------+------------------------------
Comment (by metalfurydesign):
Hiya @bradyvercher
Thanks for the plugin. I was wondering if you or @cingrosso had any tips
on how to implement it on the 2017 theme/Wordpress?
I've uploaded the plugin to the plugin folder and activated it.
I've also uploaded the .js file to a 'scripts' folder I've created.
Just not sure what to do next!
Thought maybe adding something like the following to the function.php
file?
{{{
<script type="text/javascript" src="http://www.website.co.uk/scripts
/custom-header-youtube.js"></script>
}}}
Any tips would be appreciated.
Replying to [comment:2 bradyvercher]:
> I've looked into this a bit and there isn't really a great solution. The
iframe that contains the video is automatically stretched to fill the
screen, but YouTube has a resize handler that adjusts the dimensions of
the video so that it always fits the screen rather than fill the iframe as
desired.
>
> I did go ahead and [https://github.com/bradyvercher/custom-header-
youtube put together a quick plugin] that attempts to counteract YouTube's
behavior by resizing the iframe to ensure the video always fills the
container. I haven't done much testing with Twenty Seventeen and it only
works with widescreen videos at the moment, but otherwise it should be
pretty solid.
>
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39893#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list