[wp-trac] [WordPress Trac] #42321: Menu title field does not clear invalid class (was: Issue in create a new menu)

[WordPress Trac]

#42321: Menu title field does not clear invalid class
----------------------------------------+---------------------------------
 Reporter:  ritukaushal5693             |       Owner:  ashokrd2013
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Menus                       |     Version:  4.8.2
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  ui, administration
----------------------------------------+---------------------------------
Changes (by welcher):

 * owner:   => ashokrd2013
 * status:  new => assigned


Old description:

> Hey!!
> There is bug in creating a new menu. When we create the new menu and not
> give any menu name and click on create a menu button than validation is
> shown in Menu name option. When we Fill the name of the menu validation
> color not changed. It’s still showing in red color. And Validation link
> is not showing in second create menu button.

New description:

 When we create the new menu and do not give any menu name and click on
 create a menu button than validation is shown in Menu name option. When we
 Fill the name of the menu validation color not changed. It’s still showing
 in red color. And Validation link is not showing in second create menu
 button.

--

Comment:

 @ashokrd2013 I've added some change to your patch to ensure that we're
 defining the JS vars before using them and to add some more spacing for
 readability. Great work!

 Originally, this ticket also called out only one button having the red
 outline after the submit. I don't think it should be there at all. It
 seems like awkward UX and looks horrible ( to my color blind eyes anyway
 ). As such, I think we should stop it from being added to the button at
 all.

 This is not going to make it before 4.9 RC ( the deadline for bugs is
 today ) so let's try to get that added to this patch and we'll aim for the
 next release.

 I'm going to assign this to @ashokrd2013 but if anyone wants to work on it
 ( looking at you @piyush9100 :) ) please feel free to!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42321#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform