[wp-trac] [WordPress Trac] #42321: Issue in create a new menu

[WordPress Trac]

#42321: Issue in create a new menu
----------------------------------------+---------------------------------
 Reporter:  ritukaushal5693             |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Menus                       |     Version:  4.8.2
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  ui, administration
----------------------------------------+---------------------------------
Changes (by welcher):

 * keywords:  good-first-bug has-patch => good-first-bug needs-patch


Comment:

 @ashokrd2013 thanks for the update.

 My only suggestion would be to make underscore a dependency when `nav-
 menu` is registered in`script-loader.php` rather than calling
 `wp_enqueue_script` in `nav-menus.php` - https://github.com/WordPress
 /wordpress-develop/blob/master/src/wp-includes/script-loader.php#L878

 Beyond the change above, there are still some best practices issues in
 regards to whitepace for example `!menuNameVal` should be `! menuNameVal`
 etc. Have a read here for more details -
 https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/javascript/#spacing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42321#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform