[wp-trac] [WordPress Trac] #42365: Error while theme update from customizer

WordPress Trac noreply at wordpress.org
Sat Oct 28 09:12:09 UTC 2017


#42365: Error while theme update from customizer
--------------------------+-----------------------------
 Reporter:  Mahesh901122  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Customize     |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:  ui            |
--------------------------+-----------------------------
 I have tested on '''https://wordpress.org/wordpress-4.9-beta4.zip'''

 I'm updating theme from customizer. Theme updated successfully. But, Could
 not show the `spinner` & trigger the JS error: `Uncaught TypeError: Cannot
 read property 'counts' of undefined` in file
 `updates.js?ver=4.9-beta4:345`

 -----

 How to reproduce?
 - I have updated "Twenty Sixteen" theme version with 1.2.
 - Goto `Customizer -> Themes -> Installed Themes` and update the "Twenty
 Sixteen".

 Check this video - http://bsf.io/zu64m

 -----

 I'm tried to apply the patch but not found the root of this error.

 After some digging I found that the `#update-theme` not found while theme
 update.
 {{{
 // Update the theme details UI.
 $notice = $( '#update-theme' ).closest( '.notice' ).removeClass( 'notice-
 large' );
 }}}

 The `#update-theme` is added though JS localize though function
 `get_theme_update_available()`. Maybe the localize variables are not found
 here.

 Screenshot - http://bsf.io/x10cu

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42365>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list