[wp-trac] [WordPress Trac] #39730: Checking if wp_new_comment() return value is a WP_Error

[WordPress Trac]

#39730: Checking if wp_new_comment() return value is a WP_Error
---------------------------------------+------------------
 Reporter:  enrico.sorcinelli          |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  4.9
Component:  Comments                   |     Version:  4.8
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+------------------
Changes (by peterwilsoncc):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch


Comment:

 In [attachment:39730.diff]:

 * reverts `wp_send_json_error()` back to `wp_die()` from
 [attachment:39730.6.patch]  (this was my mis-steer, sorry folks)
 * fixes a minor code style violation
 * removes internationalisation from filter used in tests to prevent false
 errors in languages in other than english (the assertion does not use
 i18n)

 I can reproduce the error described, the patch fixes it. Will commit
 momentarily.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39730#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform