[wp-trac] [WordPress Trac] #42212: Customize Themes: Unstick open filters
WordPress Trac
noreply at wordpress.org
Sat Oct 21 23:20:35 UTC 2017
#42212: Customize Themes: Unstick open filters
------------------------------+-------------------------------
Reporter: melchoyce | Owner: celloexpressions
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.9
Component: Customize | Version:
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: ui
------------------------------+-------------------------------
Changes (by celloexpressions):
* keywords: has-patch needs-testing => has-patch commit
* status: closed => reopened
* resolution: fixed =>
Comment:
[41903] introduced a new method in `WP_Customize_Themes_Section` for
rendering the filter drawer template. However, the call to that function
was only made if it was the `wporg` instance. To make the distinct
function useful for modular extensibility, the conditional should be
located within the new method, and it should always be called. That way,
custom themes sections can use custom filter bars and custom filter
drawers by overriding those specific methods, without overriding the
entire section template. If core introduces a filter drawer for installed
themes (for multisite, for example), the new method can similarly be used
without changing the entire template. This will also provide better future
compatibility for any custom section types.
See [attachment:42212.2.diff].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42212#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list