[wp-trac] [WordPress Trac] #42277: Remove useless tests from `Tests_Basic`

WordPress Trac noreply at wordpress.org
Thu Oct 19 09:05:39 UTC 2017


#42277: Remove useless tests from `Tests_Basic`
------------------------------+-----------------------------
 Reporter:  Frank Klein       |      Owner:
     Type:  enhancement       |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  Build/Test Tools  |    Version:  trunk
 Severity:  normal            |   Keywords:
  Focuses:                    |
------------------------------+-----------------------------
 The `Tests_Basic` class contains several tests, which do not seem to be
 testing anything useful:
 - `test_globals()` and `test_globals_bar()`: The bug in question has been
 fixed for a long time, plus issues with PHPUnit should be handled
 upstream.
 - `test_setting_nonexistent_arrays()`, `test_magic_getter()`,
 `test_subclass_magic_getter()`, `test_call_method()`,
 `test_subclass_magic_getter()`, `test_call_method()`,
 `test_subclass_call_method()`, `test_subclass_isset()`, and
 `test_subclass_unset()` all needlessly test basic PHP features.
 - `_switch_order_helper()` is unused, except in it's `test_switch_order()`
 test, and since `Tests_Basic` is a test class, it can be removed.

 Some of these tests have been added for HHVM support, but are no longer
 needed after this support was removed as part of #40548.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42277>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list