[wp-trac] [WordPress Trac] #41870: Code Editor: Add grunt task for building new CodeMirror bundles from external dependencies

WordPress Trac noreply at wordpress.org
Wed Oct 18 00:39:44 UTC 2017


#41870: Code Editor: Add grunt task for building new CodeMirror bundles from
external dependencies
------------------------------+------------------------------
 Reporter:  westonruter       |       Owner:  adamsilverstein
     Type:  task (blessed)    |      Status:  assigned
 Priority:  high              |   Milestone:  4.9
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:  javascript
------------------------------+------------------------------
Changes (by westonruter):

 * keywords:  has-patch => needs-patch


Comment:

 I can confirm that [attachment:41870.9.diff] does fixes the issue with
 HTMLHint passing the JSHint config properly.

 To recap where we're at after Slack DM:

 * The current webpack build causes very strange behavior in Customizer
 where all panels and sections get hidden with `display:none` except for
 the Widgets panel.
 * It would be ideal if `JSHint`, `HTMLHint`, `CSSLint`, and `jsonlint`
 didn't have to be added to the global scope in addition to `wp`. I recall
 being able to avoid this by using browserify-shim since the JSHint-lint
 addon in CodeMirror is not updated to work with modules. See
 https://github.com/codemirror/CodeMirror/pull/4962#issuecomment-329017493

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41870#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list