[wp-trac] [WordPress Trac] #42239: Delete Selected button stays active even all selected images in media library are deselected

WordPress Trac noreply at wordpress.org
Tue Oct 17 17:47:22 UTC 2017


#42239: Delete Selected button stays active even all selected images in media
library are deselected
------------------------------+-----------------------------------------
 Reporter:  subrataemfluence  |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Media             |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  javascript, administration
------------------------------+-----------------------------------------

Comment (by adamsilverstein):

 In [attachment:42239.2.diff]
 * Trigger the controller `selection:toggle` event when clicking the
 'check' box in the media bulk selection mode.

 The `DeleteSelected` button (wp-includes/js/media/views/button/delete-
 selected.js) listens for this event on the controller and calls
 `toggleDisabled` which properly enables or disables the model, triggering
 a button rerender in the correct state. Before this patch this worked only
 when clicking on the images themselves to toggle, this extends that to the
 check box in the upper right corner of each image.

 @subrataemfluence can you give this patch a test and verify it resolves
 the issue you were seeing?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42239#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list