[wp-trac] [WordPress Trac] #36279: Add an "add new menu" button to the menu locations section in the customizer
WordPress Trac
noreply at wordpress.org
Tue Oct 17 10:12:43 UTC 2017
#36279: Add an "add new menu" button to the menu locations section in the
customizer
------------------------------+-----------------------
Reporter: celloexpressions | Owner: bpayton
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 4.9
Component: Customize | Version: 4.3
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui
------------------------------+-----------------------
Comment (by bpayton):
Replying to [comment:17 melchoyce]:
> Replying to [comment:16 bpayton]:
> > Before wrapping up, I need to:
> > - Confirm what we want to do with the existing Edit Menu button.
@melchoyce, what are your thoughts?
>
> What's the issue? AFAIK it should stay the same.
Based on my reading of the discussion, I thought editing menus from All
Locations was being reconsidered, but we cleared up my misunderstanding in
#core-customize.
Because the client-side `api.Menus.MenuLocationsControl` relies on both
server-side and client-side rendering, I am not sure it is reasonable to
add qunit tests. @westonruter, is there anything you'd suggest here?
Not including unit tests, this change is ready for review here:
https://github.com/xwp/wordpress-develop/pull/285
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36279#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list