[wp-trac] [WordPress Trac] #41870: Code Editor: Add grunt task for building new CodeMirror bundles from external dependencies

WordPress Trac noreply at wordpress.org
Mon Oct 16 17:53:46 UTC 2017


#41870: Code Editor: Add grunt task for building new CodeMirror bundles from
external dependencies
------------------------------------+------------------------------
 Reporter:  westonruter             |       Owner:  adamsilverstein
     Type:  task (blessed)          |      Status:  assigned
 Priority:  high                    |   Milestone:  4.9
Component:  Build/Test Tools        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  javascript
------------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:  needs-patch => has-patch dev-feedback


Comment:

 In [attachment:41870.diff]:
 * Use webpack to build codemirror.js from manifest based on
 https://github.com/WordPress/better-code-editing/pull/92/files
 * Switch script loader to use the unminified script when SCRIPT_DEBUG is
 true
 * Include codemirror 5.30 from npm
 * Removed the minified file, including the unminified file - the minified
 file should be created in the release build (i'll test that)

 @westonruter I wasn't sure about the linters, you want to bundle those as
 well so its one single bundle?

 Also, thinking I should remove the watch on these files, any reason not
 to?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41870#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list