[wp-trac] [WordPress Trac] #42184: Customizer theme install getting stuck on downloading

[WordPress Trac]

#42184: Customizer theme install getting stuck on downloading
--------------------------+-------------------------------
 Reporter:  helen         |       Owner:  celloexpressions
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-------------------------------
Changes (by westonruter):

 * keywords:  has-patch => needs-patch
 * owner:  helen => celloexpressions


Comment:

 The problem is going deeper than just adding the credential modal template
 in [attachment:42184.0.diff]. When I add it, I do get the modal as
 expected in [attachment:credential-modal.png]. But when I cancel out of
 that modal, I then get some weird behavior as can be seen in [attachment
 :after-credential-modal-cancel.png].

 I think it may have to do with this `credential-modal-cancel` event
 handler running in the unexpected context of the Customizer:
 https://github.com/WordPress/wordpress-
 develop/blob/850db3c6a05af31efdd4ec982536cae4c496ae61/src/wp-
 admin/js/updates.js#L1780-L1825

 In addition the buttons both getting the “Install” label, then when I try
 clicking on them they do nothing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42184#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform