[wp-trac] [WordPress Trac] #42221: Code Editors: remove redundant padding in RTL view

[WordPress Trac]

#42221: Code Editors: remove redundant padding in RTL view
-----------------------------------------+----------------------
 Reporter:  ramiy                        |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  4.9
Component:  Administration               |     Version:  trunk
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, rtl
-----------------------------------------+----------------------
Changes (by afercia):

 * focuses:  rtl, administration => ui, rtl
 * component:  General => Administration
 * milestone:  Awaiting Review => 4.9


Comment:

 `plugin-editor-php` and `theme-editor-php` set an inline style on the
 first level list:
 `<ul role="group" style="padding-left: 0;">`

 Inline styles with properties involving left/right values are no good for
 RTL because the build process for RTL processes just the CSS files, not
 inline styles in the markup. This CSS declaration should be set in a CSS
 file, properly targeting the first level `<ul>`. /cc @WraithKenny

 On a side note, WordPress doesn't do the following type of indentation in
 the PHP files:

 {{{
         <ul role="tree" aria-labelledby="theme-files-label">
                 <li role="treeitem" tabindex="-1" aria-expanded="true"
                         aria-level="1"
                         aria-posinset="1"
                         aria-setsize="1">
                         <ul role="group" style="padding-left: 0;">
                                 <?php wp_print_theme_file_tree(
 wp_make_theme_file_tree( $allowed_files ) ); ?>
                         </ul>
                 </li>
         </ul>
 }}}

 This is PHP, not JS, and indenting code this way actually produces a lot
 of white space in the markup.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42221#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform