[wp-trac] [WordPress Trac] #42114: Customize Menus: UX Improvements
WordPress Trac
noreply at wordpress.org
Sat Oct 14 08:51:47 UTC 2017
#42114: Customize Menus: UX Improvements
----------------------------+-----------------------
Reporter: melchoyce | Owner: bpayton
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 4.9
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui
----------------------------+-----------------------
Comment (by bpayton):
I made updates to better accommodate other scenarios where we shake UI to
draw the user's attention (#42211). It would be good to confirm the
general direction before writing tests for the reusable function.
Here's a PR where I'm managing the work. I've been working this way with
Weston but am happy to provide a patch if another reviewer prefers.
https://github.com/xwp/wordpress-develop/pull/284
A couple of concerns:
- Finding a good place to share an internal function across files without
adding to the public namespace `api.utils`.
- Naming: I don't like the names I used but haven't thought of better
(e.g., all names beginning with `pointOut`).
Thanks!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42114#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list