[wp-trac] [WordPress Trac] #42180: Escape key does not work on Attachment Detail popup when navigating fast

WordPress Trac noreply at wordpress.org
Fri Oct 13 18:20:39 UTC 2017


#42180: Escape key does not work on Attachment Detail popup when navigating fast
------------------------------+-----------------------------------------
 Reporter:  subrataemfluence  |       Owner:  adamsilverstein
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.9
Component:  Media             |     Version:  4.0
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  javascript, administration
------------------------------+-----------------------------------------
Changes (by adamsilverstein):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"41856"]:
 {{{
 #!CommitTicketReference repository="" revision="41856"
 Media Grid: Fix escape key sometimes failing to close details modal.

 Fix an issue where the escape key would no longer close the attachment
 details modal after attempting to navigate over the navigation boundaries
 (by clicking the left arrow key on the first media item or clicking the
 right arrow key on the last media item). Remove a focus blur which caused
 the underlying Backbone View to not receive the 'keydown' event.

 Props subrataemfluence, afercia.
 Fixes #42180.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42180#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list