[wp-trac] [WordPress Trac] #42111: Heads up! modal better responsive on narrow screens

[WordPress Trac]

#42111: Heads up! modal better responsive on narrow screens
-------------------------------------------------+-------------------------
 Reporter:  sami.keijonen                        |       Owner:  helen
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.9
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:  ui
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by helen):

 @Mirucon Your patch removes styling from other places that use
 `.notification-dialog` - I know it's hard to figure out what gets used
 where, so in the future I would suggest doing a search for usages of the
 class so that you test each of those instances. The toolbar problem is
 that it shouldn't be accessible at all, making compensation for the menu
 being open unnecessary, for instance.

 In the interest of time, I've attached the simplest possible patch as
 [attachment:42111.2.diff], which also happens to fix the FTP credentials
 dialog on narrow screens. Some screenshots:

 FTP before:

 [[Image(http://s.hyhs.me/n3le/image.png, 375px)]]

 FTP after:

 [[Image(http://s.hyhs.me/n3Rb/image.png, 375px)]]

 File editor warning after:

 [[Image(http://s.hyhs.me/n3SL/image.png, 375px)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42111#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform