[wp-trac] [WordPress Trac] #42189: MediaElement.js 4.2 is not backward compatible with 2.2

[WordPress Trac]

#42189: MediaElement.js 4.2 is not backward compatible with 2.2
--------------------------+-----------------------
 Reporter:  bradyvercher  |       Owner:  rafa8626
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9
Component:  Media         |     Version:  trunk
 Severity:  major         |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------

Comment (by bradyvercher):

 @rafa8626 Thanks! Those changes look like they'll help clear up some of
 the errors. A couple of things I'm still noticing:

 1) `player.controls` and `player.container` don't look like they're being
 converted to jQuery collections in the migration script.

 2) It looks like the
 [https://github.com/mediaelement/mediaelement/blob/37c0f9d16884b9a379a091e442677c56af09727e/src/js/utils/dom.js#L118
 visible() method here] may be passed a jQuery object at some point, which
 throws an error. That probably needs to be dereferenced. That's the only
 one I saw throwing an error, but I'm not sure if some of those other
 methods will ever get passed a jQuery object, too.

 3) I haven't tracked this one down, but every element in the `layers` div
 is receiving an inline style with `width: 100%` on it now.

 This is giving me hope that it may actually be possible to make this
 upgrade backward compatible. There are a couple of other minor things I've
 noticed, but I think if we can get those few issues worked out, it should
 prevent most of the JS errors on upgrade.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42189#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform