[wp-trac] [WordPress Trac] #40669: Proper query cache invalidation on queries meta queries

WordPress Trac noreply at wordpress.org
Thu Oct 12 15:11:10 UTC 2017


#40669: Proper query cache invalidation on queries meta queries
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
     Type:  defect (bug)                         |  boonebgorges
 Priority:  normal                               |      Status:  assigned
Component:  Query                                |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  has-patch dev-feedback needs-unit-   |  Resolution:
  tests                                          |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 @spacedmonkey - Thanks again for the updated patches, and sorry for the
 delay in review.

 The comment query issue is fixed in [41848]. I modified your tests a bit
 so that they were in a more appropriate file, so that they generated fewer
 fixtures, and so that they tested results a bit more precisely.

 Post queries are currently uncached except for in the case of
 `get_pages()`. So the bug fixed by [attachment:40669-posts.diff] is in
 `get_pages()` specifically. I'll add tests that reflect this. If we one
 day use cache incrementors to cache other post queries, we can think about
 making the tests more general.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40669#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list