[wp-trac] [WordPress Trac] #24048: Code Editors: Increase the usability of Code Editor's files list

[WordPress Trac]

#24048: Code Editors: Increase the usability of Code Editor's files list
-----------------------------------------------+---------------------------
 Reporter:  Daedalon                           |       Owner:
     Type:  defect (bug)                       |      Status:  new
 Priority:  high                               |   Milestone:  4.9
Component:  Plugins                            |     Version:  3.5.1
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch ui-feedback ux-feedback  |     Focuses:  ui,
                                               |  accessibility
-----------------------------------------------+---------------------------

Comment (by westonruter):

 @WraithKenny Some feedback:

 * Instead of adding new JS files for tree links, I suggest just adding the
 JS inside of `theme-plugin-editor.js`. That is, unless we know we're going
 to use it elsewhere. If we are going to use it elsewhere, then the scripts
 should be added as dependencies for the `theme-plugin-editor` script so
 that it doesn't have to be enqueued separately.
 * The inline scripts added should be added to `theme-plugin-editor.js` as
 well.
 * `wp_print_theme_file_tree()` and `wp_print_plugin_file_tree ()` both
 take `$label` arg that doesn't have the right phpdoc type, if the default
 value is `false` and not a `string. Nevertheless, I don't even see
 `$label` being used at least in the case of `wp_print_theme_file_tree()`.

 See review with context for comments: https://github.com/xwp/wordpress-
 develop/pull/281

 An eventual enhancement would be to load the given file when clicking it
 without even navigating to a different page (just updating the URL with
 `history.pushState`).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24048#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform